Pros
Job security (less and less though nowadays) Benefits (also in jeopardy) Predictable and dependable pay and raises People (peers mostly) Anyone willing to pledge their lives to a cause so noble usually has a chance at being an awesome person. Without a doubt, the individuals you serve with and meet are the #1 pro to being in the military.
Cons
No value placed on time because time =/= money in the military Lots of dead time but you're still expected to be sitting in an office somewhere (this counts as working) No attempts at predictability in your schedule (peculiar to certain operational career fields) Despite rigorous and demanding feedback requirements, it isn't received Highly bureaucratic, no real chance to have an impact on anything as an individual because everything is so bogged down and resistant to change Basically as long as you're not a dirtbag and put your time in you have amazing job security and will steadily be promoted over the years. However, all of the smartest people I know get out because not having any possibility to use creative thought or have an impact becomes too infuriating. Thus you're left with all the yes-men and kool-aid drinkers who perpetuate the unchanging, bogged down, bureaucratic, military-industrial mess that we have in place (there are some exceptions as always but these people are constantly fighting an uphill battle and are universally on blood-pressure meds).