Good for most but not all.
Pros
The pay and benefits are great. There are always opportunities for personal and professional growth. If you work hard, show up on time, and are eager to learn, you will do just fine.
Cons
Moving every 2-4 years can be difficult, especially if you have a spouse that works. Depending on your position you may deploy more often than others (every year or every other year on average). The higher up in rank you get the less opportunities for assignments there are. You can be denied career opportunities (training, assignments) for being too persistent or not persistent enough. Mental health treatment is feared as service members don't want to get coded or med boarded so it often gets over looked. Toxic leadership is rampant and there is definitely favoritism for those who volunteer all of the time over those who k ow their job, do it well, and are decent leaders.